Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balloon toolbar should not pop up off the screen when there is still space to display it #2584

Closed
gauravjain028 opened this issue Mar 16, 2018 · 2 comments · Fixed by #14755
Closed

Balloon toolbar should not pop up off the screen when there is still space to display it #2584

gauravjain028 opened this issue Mar 16, 2018 · 2 comments · Fixed by #14755
Labels
package:build-balloon type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 67 (v40...

Comments

@gauravjain028
Copy link

When I have BalloonEditor on top in the page and I have content in P. After that if I select the text by mouse from right to left direction. Toolbar is getting displayed above the the editor itself and it is not visible. Like

screen shot 2018-03-16 at 4 12 39 pm

If I do some dom manipulation on https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/examples/builds/balloon-editor.html and remove everything from top, I can reproduce it here as well.

screen shot 2018-03-16 at 6 46 17 pm

Is there any fix for it ?
@Reinmar
Copy link
Member

Reinmar commented Mar 16, 2018

cc @oleq

@oleq
Copy link
Member

oleq commented Mar 19, 2018

It looks like the problem with the getOptimalPosition utility failing when it should respect the fitInTheViewport configuration.

image

This one needs thorough research.

@oleq oleq changed the title Balloon toolbar is opening on top, which is not visible Balloon toolbar should not pop up off the screen when there is still space to display it Mar 19, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-build-balloon Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:build-balloon labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@pszczesniak pszczesniak mentioned this issue Aug 25, 2023
Merged
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:build-balloon type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 67 (v40.0.0)
Development

Successfully merging a pull request may close this issue.

Improvements to getOptimalPosition to handle cases with scrollable ancestors ckeditor/ckeditor5
6 participants
@Reinmar @oleq @gauravjain028 @pomek @mlewand @CKEditorBot