Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon mirroring for RTL UI language #2007

Open
mlewand opened this issue Aug 29, 2019 · 4 comments
Open

Icon mirroring for RTL UI language #2007

mlewand opened this issue Aug 29, 2019 · 4 comments
Labels
domain:accessibility This issue reports an accessibility problem. domain:rtl This issue reports a problem with support for right-to-left languages. package:ui support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@mlewand
Copy link
Contributor

mlewand commented Aug 29, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.4.0

📋 Steps to reproduce

During the course of #1151 part of toolbar icons were mirrored for RTL languages:

  • Undo
  • Redo

But there mare more icons that should be mirrored:

  • Numbered list
  • Ordered list
  • To-do list

Just to name a few, but there are more icons than that.

📃 Other details that might be useful

This issue is similar to #1613, but the latter is related to icon localization, which means a custom icon based on a given UI language, e.g. change the bold icon only for one particular language.

If you'd like to see this feature implemented, add 👍 to this post.
@mlewand mlewand added domain:accessibility This issue reports an accessibility problem. package:ui status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). labels Aug 29, 2019
@mlewand mlewand added this to the backlog milestone Aug 29, 2019
@mlewand mlewand added the domain:rtl This issue reports a problem with support for right-to-left languages. label Aug 29, 2019
@niegowski
Copy link
Contributor

We should also remember about table cell properties (eg justify icon should be mirrored too).

@oleq
Copy link
Member

oleq commented Aug 24, 2020

List style icons should also be mirrored 

@kuku711
Copy link

kuku711 commented Apr 26, 2021

Idk if this is relevant to this issue but inline balloon also should be mirrored (the panel should start from the right side).
image

@jswiderski jswiderski added the support:2 An issue reported by a commercially licensed client. label Aug 25, 2021
@Reinmar Reinmar added squad:devops Issue to be handled by the Devops team. and removed squad:devops Issue to be handled by the Devops team. labels Oct 28, 2021
@kuku711
Copy link

kuku711 commented Feb 17, 2022 •
edited
Loading

toolbar of image upload wrap text/break is requires mirror too (the left option is of align right)

@pomek pomek removed this from the backlog milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:accessibility This issue reports an accessibility problem. domain:rtl This issue reports a problem with support for right-to-left languages. package:ui support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Reinmar @oleq @niegowski @pomek @jswiderski @mlewand @kuku711