Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tab key should leave the editor #1709

Closed
Reinmar opened this issue Apr 16, 2019 · 3 comments
Closed

The tab key should leave the editor #1709

Reinmar opened this issue Apr 16, 2019 · 3 comments
Labels
domain:accessibility This issue reports an accessibility problem. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 16, 2019

The Tab key should leave the editor.

Currently, the Tab key cycles through nested editables. This is native behaviour implemented by browsers and it doesn't make much sense. The user will not understand that when he/she is in some place in the text, the Tab key will move them to the next editable element, which may be far from their current context. Plus, to make editor integrate well with forms and other multi-input apps, the Tab key should allow leaving the editor and moving forward to the next input.

However, as @mlewand pointed out (f2f :P), if the editor is a central place of the application, we need to allow the application to decide what to do when the user presses this key.

Related issues (some may need to be resolved together with this):

@Reinmar Reinmar added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature. labels Apr 16, 2019
@Reinmar Reinmar added this to the next milestone Apr 16, 2019
@mlewand mlewand added the domain:accessibility This issue reports an accessibility problem. label Jul 15, 2019
@panta82
Copy link

panta82 commented Aug 1, 2021

Is there some hack or plugin that can be implemented now, to help ease the accessibility pains?

Eg. a way to leave the editor focus on a key press?

@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Aug 24, 2023
@godai78
Copy link
Contributor

godai78 commented May 7, 2024

Wasn't this covered with recent changes where the Tab navigates between focusable fields?

@Witoso
Copy link
Member

Witoso commented May 7, 2024

Yep, done in v41.3.0 via #15506.

@Witoso Witoso closed this as completed May 7, 2024
@Witoso Witoso added this to the iteration 73 (v41.3.0) milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

7 participants