Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement attribute properties #1659

Closed
mlewand opened this issue Mar 28, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1711
Closed

Implement attribute properties #1659

mlewand opened this issue Mar 28, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-engine#1711
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 23

Comments

@mlewand
Copy link
Contributor

mlewand commented Mar 28, 2019

Is this a bug report or feature request?

🆕 Feature request

💻 Version of CKEditor

CKEditor v5 @ 12.0.0

📋 Steps to reproduce

Based on discussion in #908 (comment) emerged the idea to provide an API that will allow to mark attributes with metadata.

First we need to use it to describe whether or not attribute should be considered as visual formatting or not.

The default implementation will not restrict property names, so it could be used by plugin developers for better extensibility.
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). status:confirmed package:engine labels Mar 28, 2019
@mlewand mlewand added this to the iteration 23 milestone Mar 28, 2019
@mlewand mlewand mentioned this issue Mar 28, 2019
Closed
@oleq
Copy link
Member

oleq commented Mar 28, 2019

Just a reminder for myself: we should make this sort of metadata inspectable.

@mlewand mlewand mentioned this issue Mar 28, 2019
Merged
7 tasks
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Mar 29, 2019
@Reinmar
Merge pull request #1711 from ckeditor/t/ckeditor5/1659
1c6f83a 
Feature: Introduced `Schema#setAttributeProperties()` and `Schema#getAttributeProperties()` methods. Closes ckeditor/ckeditor5#1659.
@oleq oleq mentioned this issue Mar 29, 2019
Closed
@mlewand mlewand mentioned this issue Mar 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 23
2 participants
@oleq @mlewand