Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for callbacks in header values for Simple upload adapter #15693

Closed
Mgsy opened this issue Jan 15, 2024 · 0 comments · Fixed by #17711
Closed

Add support for callbacks in header values for Simple upload adapter #15693

Mgsy opened this issue Jan 15, 2024 · 0 comments · Fixed by #17711
Assignees
Labels
intro Good first ticket. package:upload squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Mgsy
Copy link
Member

Mgsy commented Jan 15, 2024

📝 Provide a description of the improvement

Currently, it's possible to define additional headers for the Simple upload adapter with the following config:

simpleUpload: {
	headers: {
		'X-Foo-Bar': 'Value'
	}
}

However, sometimes it might be desired to have the value dynamic (e.g. due to refreshing token), so it would be nice to add support for callbacks. 


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@Mgsy Mgsy added type:improvement This issue reports a possible enhancement of an existing feature. package:upload support:2 An issue reported by a commercially licensed client. squad:core Issue to be handled by the Core team. labels Jan 15, 2024
@Witoso Witoso added the intro Good first ticket. label Jan 15, 2024
@Mati365 Mati365 self-assigned this Jan 3, 2025
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 3, 2025
@Mati365 Mati365 closed this as completed in 4517b1c Jan 3, 2025
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 3, 2025
@CKEditorBot CKEditorBot added this to the iteration 82 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
intro Good first ticket. package:upload squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
4 participants