Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table properties toolbar is scrolling through non-editor content section also #14559

Closed
srikantyasam opened this issue Jul 10, 2023 · 3 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@srikantyasam
Copy link

📝 Provide detailed reproduction steps (if any)

  1. Opened the ckeditor feature demo url 'https://ckeditor.com/ckeditor-5/demo/feature-rich/'
  2. Removed the OOTB content , added some text along with a table as shown below.

image

  1. Select the table. Table properties toolbar section is opened

  2. Now scroll-down the page through the vertical scroll bar
    image

  3. Scroll the page down further. The table properties toolbar is scrolled through non-editor section( editor toolbar section, in this case) though the actual table is not visible in the current DOM view.

image

✔️ Expected result

Table properties toolbar should only be visible when the table is present in the DOM view. It should not be positioned beyond the editor content area and should automatically hide when the table is no-longer visible in the view(due to scroll-up/down actions)

❌ Actual result

Table properties toolbar is still shown on the UI, though table is not visible.

❓ Possible solution

?

📃 Other details

?


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@srikantyasam srikantyasam added the type:bug This issue reports a buggy (incorrect) behavior. label Jul 10, 2023
@Witoso
Copy link
Member

Witoso commented Jul 13, 2023

Thanks for reporting, this is a duplicate of #5328.

@Witoso Witoso closed this as completed Jul 13, 2023
@Witoso Witoso added resolution:duplicate This issue is a duplicate of another issue and was merged into it. domain:ui/ux This issue reports a problem related to UI or UX. labels Jul 13, 2023
@CKEditorBot CKEditorBot removed resolution:duplicate This issue is a duplicate of another issue and was merged into it. domain:ui/ux This issue reports a problem related to UI or UX. labels Jul 13, 2023
@Witoso Witoso added resolution:duplicate This issue is a duplicate of another issue and was merged into it. resolution:resolved This issue was already resolved (e.g. by another ticket). domain:ui/ux This issue reports a problem related to UI or UX. and removed resolution:resolved This issue was already resolved (e.g. by another ticket). labels Jul 14, 2023
@srikantyasam
Copy link
Author

Thanks for reporting, this is a duplicate of #5328.

@Witoso Thanks for the response on this issue.
As you marked the issue as duplicate to 5328 , and #5328 was marked closed through the recently merged PR 14630.

Does it mean we need to upgrade to latest version(38.1.1) to get this issue resolved???

We are using 'ckeditor5-build-classic' and currently on version '36.0.1' .. Please confirm ..

@Witoso
Copy link
Member

Witoso commented Jul 31, 2023

#5328 needed to be reopened as the testing phase showed some regressions, we will most likely add it to the the release after the next one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants