Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research setting aspect-ratio #14366

Closed
Tracked by #14146
Witoso opened this issue Jun 9, 2023 · 1 comment
Closed
Tracked by #14146

Research setting aspect-ratio #14366

Witoso opened this issue Jun 9, 2023 · 1 comment
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@Witoso
Copy link
Member

Witoso commented Jun 9, 2023

After #14313 we want to check if we should set on the model, and later on inline styles in the data output an aspect-ratio style.

This attribute could help us to:
1. remove height:auto style from the img.
2. show non-proportionally resized images that come from CKEditor 4 for example.

Outcome:
Research setting inline aspect-ratio based on resizedHeight & resizedWidth or fallback to attributes width and height.

@Witoso Witoso added type:task This issue reports a chore (non-production change) and other types of "todos". squad:core Issue to be handled by the Core team. labels Jun 9, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 9, 2023
@Witoso
Copy link
Member Author

Witoso commented Jun 12, 2023

Closing as duplicate of #14357.

@Witoso Witoso closed this as completed Jun 12, 2023
@CKEditorBot CKEditorBot removed the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Jun 12, 2023
@CKEditorBot CKEditorBot added this to the upcoming milestone Jun 12, 2023
@CKEditorBot CKEditorBot modified the milestones: upcoming, iteration 67 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

2 participants