Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine support for Unicode characters #2570

Closed
jodator opened this issue Jun 28, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-word-count#10
Closed

Refine support for Unicode characters #2570

jodator opened this issue Jun 28, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-word-count#10
Labels
package:word-count type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 26

Comments

@jodator
Copy link
Contributor

jodator commented Jun 28, 2019

Either here or add a follow up: this might not work with other languages which we may easily support (as not detect non-word characters):

Selection_049

related fix in mentions: https://github.com/ckeditor/ckeditor5-mention/pull/71/files#diff-1684a608a7129dc20f38e3655d982678R548

_Originally posted by @jodator in ckeditor/ckeditor5-word-count#2 (comment)
jodator referenced this issue in ckeditor/ckeditor5-word-count Jul 29, 2019
@jodator
Merge pull request #10 from ckeditor/t/5
7e7ee48 
Fix: Improve words recognition, remove enter from counted characters. Closes #4. Closes #5.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-word-count Oct 9, 2019
@mlewand mlewand added this to the iteration 26 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:word-count labels Oct 9, 2019
@msamsel msamsel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:word-count type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 26
Development

Successfully merging a pull request may close this issue.

Remove enter from counted characters ckeditor/ckeditor5-word-count
2 participants
@jodator @mlewand