Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection handler -> selection handle #4612

Closed
Reinmar opened this issue Aug 19, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-widget#110
Closed

Selection handler -> selection handle #4612

Reinmar opened this issue Aug 19, 2019 · 1 comment · Fixed by ckeditor/ckeditor5-widget#110
Assignees
@oleq
Labels
package:widget type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 27 (v15...

Comments

@Reinmar
Copy link
Member

Reinmar commented Aug 19, 2019

Handler handles something. A handle is the thing that you grab.
@Reinmar
Copy link
Member Author

Reinmar commented Aug 19, 2019

We already used the correct "handle" noun in the image resize feature.

oleq referenced this issue in ckeditor/ckeditor5-table Oct 8, 2019
@oleq
Aligned to the rename in the ckeditor5-widget package ("handler" beca…
21fa3db 
…me "handle", see ckeditor/ckeditor5-widget#99).
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Oct 8, 2019
@oleq
Aligned widget class names to the refactoring in ckeditor5-widget (se…
67c1273 
…e ckeditor/ckeditor5-widget#99).
Reinmar referenced this issue in ckeditor/ckeditor5-widget Oct 9, 2019
@Reinmar
Merge pull request #110 from ckeditor/t/99
1d35884 
Other: Renamed "handler" to "handle" in the entire package. Closes #99.

BREAKING CHANGE: The `drag-handler.svg` icon is now `drag-handle.svg`. If you use it in your integration, please update the path.

BREAKING CHANGE: The `hasSelectionHandler` option of the [`toWidget()`](https://ckeditor.com/docs/ckeditor5/latest/api/module_widget_utils.html#static-function-toWidget) utility has been renamed to `hasSelectionHandle`. Consider this change if you create your own widgets using this helper.

BREAKING CHANGE: `.ck-widget__selection-handler` and `.ck-widget_with-selection-handler` CSS classes set on widgets have been renamed to `.ck-widget__selection-handle` and `.ck-widget_with-selection-handle`. This change may affect styling in your integration.
Reinmar referenced this issue in ckeditor/ckeditor5-table Oct 9, 2019
@Reinmar
Merge pull request #221 from ckeditor/t/ckeditor5-widget/99
970ea91 
Internal: Aligned to the rename in the ckeditor5-widget package ("handler" became "handle", see ckeditor/ckeditor5-widget#99).
Reinmar referenced this issue in ckeditor/ckeditor5-theme-lark Oct 9, 2019
@Reinmar
Merge pull request #246 from ckeditor/t/ckeditor5-widget/99
202f95a 
Internal: Aligned widget class names to the refactoring in ckeditor5-widget (see ckeditor/ckeditor5-widget#99).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-widget Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:widget labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:widget type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

Successfully merging a pull request may close this issue.

t/99: Renamed "handler" to "handle" in the entire package ckeditor/ckeditor5-widget
3 participants
@Reinmar @oleq @mlewand