This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
i/6145: Replaced the getResizeObserver() helper with the ResizeObserver class #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class for performance reasons. Closes ckeditor/ckeditor5#6145.
Reinmar
reviewed
Jan 28, 2020
Reinmar
reviewed
Jan 28, 2020
Reinmar
reviewed
Jan 28, 2020
|
OK, from the code perspective this change looks good. There are 3 minor issues that I spotted. I leave the rest to you, @panr. Please verify how does it affect the case that you have, guys. And if all's fine and you like the implementation, you can merge those two PRs. |
|
PS. I updated the merge message. It's a minor BC to me so I wanted to make that explicite. |
Co-Authored-By: Piotrek Koszuliński <[email protected]>
Co-Authored-By: Piotrek Koszuliński <[email protected]>
|
LGTM 👌 Merging it. |
panr
added a commit
to ckeditor/ckeditor5-ui
that referenced
this pull request
Feb 6, 2020
… in ToolbarView. Follow-up on: ckeditor/ckeditor5-utils/pull/320
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Replaced the
getResizeObserver()helper with theResizeObserverclass for performance reasons. Closes ckeditor/ckeditor5#6145.MINOR BREAKING CHANGE: The
getResizeObserver()helper is no longer available. We recommend using theResizeObserverclass instead.Additional information
Requires:
ToolbarViewclass to theResizeObserverckeditor5-ui#538 that alignsToolbarViewto the new API.