Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The image should replace the current block if it's empty #2814

Closed
Reinmar opened this issue Jul 5, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-upload#47
Closed

The image should replace the current block if it's empty #2814

Reinmar opened this issue Jul 5, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-upload#47
Assignees
@Reinmar
Labels
intro Good first ticket. package:upload type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Jul 5, 2017

jul-05-2017 19-23-39
@Reinmar
Copy link
Member Author

Reinmar commented Jul 13, 2017

BTW, I think that if DataController#insertContent() was used it would replace the paragraph... And it uses it, so it's strange that a new block is created.

@Reinmar Reinmar self-assigned this Jul 14, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-upload Jul 27, 2017
@Reinmar
Merge pull request #47 from ckeditor/t/42
fec452d 
Fix: Fixed two issues related to dropping images. First, when dropping a file into an empty paragraph, that paragraph should be replaced with that image. Second, drop position should be read correctly when the editor is focused upon drop. Closes #42. Closes #29.

BREAKING CHANGE: `UploadImageCommand` doesn't optimize the drop position itself anymore. Instead, a separate `findOptimalInsertionPosition()` function was introduced.

BREAKING CHANGE: `UploadImageCommand` doesn't verify the type of file anymore. This needs to be done by the caller.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-upload Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added intro Good first ticket. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:upload labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
intro Good first ticket. package:upload type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

T/42: Various issues when dropping or inserting files. SRP in the command ckeditor/ckeditor5-upload
2 participants
@Reinmar @mlewand