Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make clickOutsideHandler use mousedown instead of mouseup #5391

Closed
oleq opened this issue Jul 24, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#282
Closed

Make clickOutsideHandler use mousedown instead of mouseup #5391

oleq opened this issue Jul 24, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-ui#282
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jul 24, 2017

It looks like the wrong event makes a difference:

But why we chose mouseup it the first place? (cc @Reinmar)
@oleq oleq self-assigned this Jul 24, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Jul 24, 2017
@oleq
Fix: The clickOutsideHandler helper should use mousedown instead of m…
ce6faaa 
…ouseup event. Closes #281.
oleq referenced this issue in ckeditor/ckeditor5-image Jul 24, 2017
@oleq
Internal: The clickOutsideHandler helper should use mousedown instead…
bcf6895 
… of mouseup event (see ckeditor/ckeditor5-ui#281).
@oleq
Copy link
Member Author

oleq commented Jul 24, 2017 •
edited
Loading

The event was changed to mouseup in this refactoring (issue). @oskarwrobel, do you remember why?

@oskarwrobel
Copy link
Contributor

I don't remember. There was something related to clicking on toolbar buttons while LinkBalloon is opened but I'm not sure if this was a reason for this change.

oskarwrobel referenced this issue in ckeditor/ckeditor5-ui Aug 7, 2017
@oskarwrobel
Merge pull request #282 from ckeditor/t/281
6b980b6 
Fix: The `clickOutsideHandler` helper should use `mousedown` instead of `mouseup` event. Closes #281.
oskarwrobel referenced this issue in ckeditor/ckeditor5-image Aug 7, 2017
@oskarwrobel
Merge branch 't/ckeditor5-ui/281'
0eddc64 
Tests: The clickOutsideHandler helper should use mousedown instead of mouseup event (see ckeditor/ckeditor5-ui#281).
oskarwrobel referenced this issue in ckeditor/ckeditor5-link Aug 7, 2017
@oleq @oskarwrobel
Internal: The clickOutsideHandler helper should use mousedown instead…
45ebffb 
… of mouseup event (see ckeditor/ckeditor5-ui#281).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
3 participants
@oskarwrobel @oleq @mlewand