Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StickyToolbarView should support a configurable vertical offset from the top of the page #5390

Closed
oleq opened this issue Jul 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#279
Closed

StickyToolbarView should support a configurable vertical offset from the top of the page #5390

oleq opened this issue Jul 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#279
Assignees
@oleq
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jul 19, 2017

A follow-up of https://github.com/ckeditor/ckeditor5-editor-classic/issues/60.

Related to #495.
@oleq oleq self-assigned this Jul 19, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Jul 19, 2017
@oleq
Other: StickyToolbarView should support a configurable vertical offse…
0e3800b 
…t from the top of the page. Closes #277.
Reinmar referenced this issue in ckeditor/ckeditor5-ui Jul 24, 2017
@Reinmar
Merge pull request #279 from ckeditor/t/277
245f0fa 
Feature: `StickyToolbarView` now supports a configurable vertical offset from the top of the page. Closes #277.

Also implemented the `normalizeToolbarConfig()` utility.

BREAKING CHANGE: `StickyToolbarView#limiterOffset` has been renamed to `StickyToolbarView#limiterBottomOffset`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 11
2 participants
@oleq @mlewand