Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should contextual balloon be displayed when target is out of the viewport? #5354

Closed
Reinmar opened this issue May 8, 2017 · 3 comments · Fixed by #14755
Closed

Should contextual balloon be displayed when target is out of the viewport? #5354

Reinmar opened this issue May 8, 2017 · 3 comments · Fixed by #14755
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented May 8, 2017

image

This looks bad. Especially, when scrolling the content. I'm not sure what we could do.

  • Should the toolbar be above the balloon?
  • Should we hide the balloon?
  • Should the balloon stick to the top and move no further?
@oskarwrobel
Copy link
Contributor

@oleq
Copy link
Member

oleq commented May 9, 2017

Should the toolbar be above the balloon?

Just like the dialog floats over the entire web page, the balloon should be on top because it is the actual context of the user at that particular moment. We should rather hide the balloon when they overlap.

Should we hide the balloon?

Yes. As soon as the bottom edge of the target goes off-screen.

Should the balloon stick to the top and move no further?

No, because then the balloon remains in the context of something supposedly far, far away and long forgotten by the user, thus becoming an orphan UI.

@Reinmar
Copy link
Member Author

Reinmar commented Jun 21, 2017

I'm adding it to milestone 11 to discuss this ticket's priority, but AFAIR it was blocked by the async UI API refactoring.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the backlog milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:ui labels Oct 9, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot CKEditorBot added this to the iteration 67 milestone Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:ui type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants