Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge FloatingPanelView into BalloonPanelView so only a single class remains #5334

Closed
oleq opened this issue Apr 7, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#197
Closed

Merge FloatingPanelView into BalloonPanelView so only a single class remains #5334

oleq opened this issue Apr 7, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-ui#197
Assignees
@oleq
Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 10

Comments

@oleq
Copy link
Member

oleq commented Apr 7, 2017

It turned out that FloatingPanelView requires some of the logic of BalloonPanelView to work properly in https://github.com/ckeditor/ckeditor5-editor-inline/issues/4. Maintaining 2 very similar classes seems pointless now that BalloonPanelView gets more sophisticated and FloatingPanelView is always a step behind.

A follow-up of https://github.com/ckeditor/ckeditor5-editor-inline/issues/4.
@oleq oleq self-assigned this Apr 7, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-ui Apr 10, 2017
@oskarwrobel
Merge pull request #197 from ckeditor/t/191
4b90faa 
Other: Merged `FloatingPanelView` into `BalloonPanelView`. Closes #191.

BREAKING CHANGE: `FloatingPanelView` is no longer available.
BREAKING CHANGE: `BalloonPanelView#keepAttachedTo()` has been replaced by `pin()`.
BREAKING CHANGE: Default position names in `BalloonPanelView.defaultPositions` have changed. Now prefixed with `arrow_`.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 10 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:task This issue reports a chore (non-production change) and other types of "todos". package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 10
Development

Successfully merging a pull request may close this issue.

T/191: Merged FloatingPanelView into BalloonPanelView ckeditor/ckeditor5-ui
2 participants
@oleq @mlewand