Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List component doesn't handle the Enter and Space keys #5310

Closed
Reinmar opened this issue Feb 2, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#265
Closed

List component doesn't handle the Enter and Space keys #5310

Reinmar opened this issue Feb 2, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#265
Assignees
@oleq
Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented Feb 2, 2017

feb-02-2017 10-51-47

Enter and space keys on buttons are handled, so should be in this case too.

BTW, there's also that issue that the UI events' callbacks don't focus the editor before executing commands. Perhaps, we should work on all that together.
@Reinmar
Copy link
Member Author

Reinmar commented Feb 2, 2017

The same if you press Tab in this case:

image

The caret is in the list item. Pressing Tab indents that item instead of moving the focus to the balloon.

@oleq oleq self-assigned this Jul 4, 2017
oleq referenced this issue in ckeditor/ckeditor5-ui Jul 5, 2017
@oleq
Fix: List items should handle Enter and Space key press when focused.…
0d725bf 
… Closes #153.
oskarwrobel referenced this issue in ckeditor/ckeditor5-ui Jul 6, 2017
@oskarwrobel
Merge pull request #265 from ckeditor/t/153
403b64a 
Fix: List items should handle Enter and Space key press when focused. Closes #153.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/153: List items should handle Enter and Space key press when focused ckeditor/ckeditor5-ui
3 participants
@Reinmar @oleq @mlewand