Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API extension and improvements for editor-inline #5308

Closed
oleq opened this issue Jan 27, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#156
Closed

API extension and improvements for editor-inline #5308

oleq opened this issue Jan 27, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#156
Assignees
@oleq
Labels
package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 9

Comments

@oleq
Copy link
Member

oleq commented Jan 27, 2017

A follow-up of https://github.com/ckeditor/ckeditor5-editor-inline/issues/1.

Some changes are required for editor-inline to work properly:

  1. View.destroy() should not call View#element.remove(). The inline editor is given an existing element in DOM and it definitely should not nuke it. Besides, it turned out that View removing its #element from DOM on destroy() is doing a job of ViewCollection; it's obsolete.
  2. Template.apply() should preserve original values of attributes. The inline editor should not destroy existing classes and so on, it's only borrowing the element for its lifetime and should be only concerned with own classes.
  3. Implement Template.revert() to clean–up after 2. and revert the element to the same state before Editor.create().
@oleq oleq self-assigned this Jan 27, 2017
@oleq
Copy link
Member Author

oleq commented Jan 27, 2017

Editor-inline also requires the FloatingToolbarView which should be delivered by this package.

Reinmar referenced this issue in ckeditor/ckeditor5-ui Mar 7, 2017
@Reinmar
Merge pull request #156 from ckeditor/t/152
cb606d7 
Feature: Implemented features necessary for creating inline editors UI – `FloatingPanelView` class, `Template.revert()` method and `enableToolbarKeyboardFocus()` util. Closes #152.

BREAKING CHANGE: The `ui/balloonpanel/balloonpanelview` module was renamed to `ui/panel/balloon/balloonpanelview`. See #152.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 9 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ui labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:ui type:feature This issue reports a feature request (an idea for a new functionality or a missing option). type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 9
Development

Successfully merging a pull request may close this issue.

t/152: Implemented FloatingToolbarView and Template.revert() ckeditor/ckeditor5-ui
2 participants
@oleq @mlewand