This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added styles for upload complete icon #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkonopka
changed the title
oleq
reviewed
May 18, 2018
| } | ||
| } | ||
|
|
||
| @keyframes ck-fade-in { |
There was a problem hiding this comment.
These names ck-fade-in and -out feel very generic to me. If we ever decide to make them global, they would already be taken. I'd use something with upload-complete-icon instead to stay on the safe side.
There was a problem hiding this comment.
Yeah, you are right, fixed 👍
Until we don't have a global animations.css file, animations should be dedicated to the component.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added styles for upload complete icon (see https://github.com/ckeditor/ckeditor5-image/issues/204).
Additional information
Requires: ckeditor/ckeditor5-image#205