Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsequent behaviour when switching "table row" off #3187

Closed
Reinmar opened this issue Jun 8, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#90
Closed

Inconsequent behaviour when switching "table row" off #3187

Reinmar opened this issue Jun 8, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-table#90
Assignees
@jodator
Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 20

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 8, 2018

jun-08-2018 11-20-45

  1. Make a table with 6 header rows.
  2. Place the caret in the 3rd row.
  3. Open the "row" options. The "header row" option is on. This is OK.
  4. You click it to switch the header rows off.

Expected: Header rows should stay only on 1st and 2nd rows. 3-6 rows should be turned into normal rows.

Actual: Only rows 4-6 are changed. This doesn't make sense because it means that the "header row" option will still remain on for the 3rd row.
@jodator jodator self-assigned this Jul 16, 2018
@jodator
Copy link
Contributor

jodator commented Jul 16, 2018

@Reinmar adding this to the next iteration as it's going to be a quick fix. Also this gets constantly reported internally as new bug...

oleq referenced this issue in ckeditor/ckeditor5-table Jul 26, 2018
@oleq
Merge pull request #90 from ckeditor/t/34
bce6766 
Fix: Toggling headers should always include the column or row the selection is anchored to. Closes #34.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

Fix: Switching heading columns/rows off will now behave as expected. ckeditor/ckeditor5-table
3 participants
@Reinmar @jodator @mlewand