-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ParagraphButtonUI #3307
Comments
We had a F2F talk about providing translations for the plugin. Both This case has already popped out and its ticket is waiting for the PR: https://github.com/ckeditor/ckeditor5-dev/issues/376. |
Can we use the translation available in the heading package for now? Or is the scope limited to each package + core? |
We check for duplications while we're gathering sources to upload: https://github.com/ckeditor/ckeditor5-dev/blob/6c69057249c8db63f0342fce7643b8707d3dc634/packages/ckeditor5-dev-env/tests/translations/collect-utils.js#L227-L239 |
But it's about repeated context. And is the paragraph feature able to use the translation from the heading feature? Or does that fall into the "repeated context" check? |
BTW, I may avoid using |
It should build, translations are stored in the |
Feature: Introduced ParagraphButtonUI plugin. Closes #33.
ParagraphButtonUI should be created, similar to: https://github.com/ckeditor/ckeditor5-heading/issues/104, with the default icon for the paragraph. Plugin should be optional, not required by Paragaph plugin.
The text was updated successfully, but these errors were encountered: