Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a basic support for embedding the media #2727

Closed
oleq opened this issue Jul 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-media-embed#2
Closed

Add a basic support for embedding the media #2727

oleq opened this issue Jul 26, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-media-embed#2
Assignees
@oleq
Labels
package:media-embed type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 20

Comments

@oleq
Copy link
Member

oleq commented Jul 26, 2018

A follow-up of #1126.
@oleq oleq self-assigned this Jul 26, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-engine Aug 23, 2018
@Reinmar
Merge pull request #1506 from ckeditor/t/ckeditor5-media-embed/1
49cd795 
Other: Made the view's `stringify()` dev util output the content of the `UIElement` (see ckeditor/ckeditor5-media-embed#1).
Reinmar referenced this issue in ckeditor/ckeditor5-ui Aug 24, 2018
@Reinmar
Merge pull request #439 from ckeditor/t/ckeditor5-media-embed/1
81aaea4 
Feature: Allowed displaying an error message next to the `LabeledInputVIew` (see ckeditor/ckeditor5-media-embed#1).
Reinmar referenced this issue in ckeditor/ckeditor5-theme-lark Aug 24, 2018
@Reinmar
Merge pull request #196 from ckeditor/t/ckeditor5-media-embed/1
1b3ae62 
Feature: Added styles for errors in the labeled inputs. See ckeditor/ckeditor5-media-embed#1.
Reinmar referenced this issue in ckeditor/ckeditor5-media-embed Aug 24, 2018
@Reinmar
Merge pull request #2 from ckeditor/t/1
4c9b642 
Feature: The basic media embed feature. Closes #1.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-media-embed Oct 9, 2019
@mlewand mlewand added this to the iteration 20 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:media-embed labels Oct 9, 2019
This was referenced Oct 11, 2019
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:media-embed type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 20
Development

Successfully merging a pull request may close this issue.

T/1: The basic media embed feature ckeditor/ckeditor5-media-embed
2 participants
@oleq @mlewand