This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Removed LinkElement #163
Merged
Removed LinkElement #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjasiun
reviewed
Jan 24, 2018
| linkElement.priority = 5; | ||
|
|
||
| return linkElement; | ||
| } |
There was a problem hiding this comment.
Do we need a separate file for these methods? I mean they are used only once and I don't think this code will be used again. I think we could just keep it in-place.
There was a problem hiding this comment.
Why do you think that link will never be created by any other feature? I actually think that the chance is very high for this (by 3rd party code).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Removed LinkElement, using custom properties instead. Closes ckeditor/ckeditor5#4817.