You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When running tests for Link feature I discovered interesting thing. All tests passes, but there are a lot of errors in console: @Reinmar suggested that it is connected with the fact that init() is fired asynchronously, after the plugin is already destroyed.
Possible solutions:
Fix tests so this won't happen. Use some promises to handle asynchronous initialization.
Fix Link / LinkFormView code so it won't happen. Make the plugin destroy itself only after it is inited, or maybe just abandon initialisation if the plugin was destroyed.
Or we need a complex solution for destroying editor that will also operate on Promises.
The text was updated successfully, but these errors were encountered:
First, we should check whether this is not a simple issue in the tests or the code. I guess it is.
However, we'll have to think, at some point, how to handle destroy() calls while init() takes place. This is a general issue which concerns the entire UI and the editor classes. There are two options:
throw when a component isn't yet initialised – simple and verbose,
automatically defer destroy until the component has been intialised – more problematic and I think quite risky but more graceful.
Fix: Link Plugin should manage focus when the balloon is open. Made Link Plugins #showPanel() and #hidePanel() methods protected. Closes #95. Closes #94.
When running tests for
Link
feature I discovered interesting thing. All tests passes, but there are a lot of errors in console:@Reinmar suggested that it is connected with the fact that
init()
is fired asynchronously, after the plugin is already destroyed.Possible solutions:
Link
/LinkFormView
code so it won't happen. Make the plugin destroy itself only after it is inited, or maybe just abandon initialisation if the plugin was destroyed.The text was updated successfully, but these errors were encountered: