Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputView value should be updated each time panel is showed #4765

Closed
szymonkups opened this issue Jan 9, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-link#120
Closed

InputView value should be updated each time panel is showed #4765

szymonkups opened this issue Jan 9, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-link#120
Assignees
@oleq
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@szymonkups
Copy link
Contributor

Now InputView is updated by binding its value to link command value. But in situation when balloon panel is closed with Cancel button and reopened again on the same link, InputView and DOM element values will not be updated (because command value will not change). Value should be set again each time balloon panel is showed.

Before fixing this, we should close: https://github.com/ckeditor/ckeditor5-ui/issues/135
@oleq oleq self-assigned this May 15, 2017
oleq referenced this issue in ckeditor/ckeditor5-link May 15, 2017
@oleq
Fix: The URL field's value should be updated each time the form shows…
af224ba 
… up. Closes #78.
szymonkups referenced this issue in ckeditor/ckeditor5-link May 15, 2017
@szymonkups
Merge pull request #120 from ckeditor/t/78
3b702aa 
Fix: The URL field's value should be updated each time the form shows up. Closes #78.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
@mmichaelis mmichaelis mentioned this issue Jun 17, 2021
Open
mmichaelis added a commit to CoreMedia/ckeditor-plugins that referenced this issue Jun 17, 2021
@mmichaelis
fix(link-plugin): Clear Target And Behavior on Reopening Form View
c81a36b 
Similar to `LinkUI` from CKEditor's Link Feature we must ensure, that
target input field and behavior selector are reset each time the form
view is opened.

The previous approach only covered the use-case of doing so from action
view by listening to edit-button. But, this neither deals with Ctrl+K
keystroke nor with toolbar action.

The only feasible workaround we found, was adding a decorator to the
private method `LinkUI#_addFormView`, and thus refers to missing
extension points as reported at ckeditor/ckeditor5#9730.

See-also: ckeditor/ckeditor5#4765
See-also: ckeditor/ckeditor5#4793
See-also: ckeditor/ckeditor5#9730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/78: The URL field's value should be updated each time the form shows up ckeditor/ckeditor5-link
3 participants
@oleq @szymonkups @mlewand