Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The link panel is not displayed when selection spans the entire link element #4730

Closed
oleq opened this issue Sep 9, 2016 · 7 comments · Fixed by ckeditor/ckeditor5-link#122
Assignees
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@oleq
Copy link
Member

oleq commented Sep 9, 2016

  1. Focus editable.
  2. Select the link, i.e. like this

image

Expected: Link panel appears for the selected link.

Actual: Nothing happens.

@oskarwrobel oskarwrobel self-assigned this Sep 12, 2016
@oleq
Copy link
Member Author

oleq commented Sep 12, 2016

Alright. In F2F talk we decided with @oskarwrobel that this behaviour is valid and even expected in some sort of way. However, as @oskarwrobel pointed out, the panel should appear on double click on the link. I think it makes sense. It is something v4 users may be used to.

@oleq
Copy link
Member Author

oleq commented Sep 12, 2016

OTOH, double clicking might be reserved for other editing tasks, like the user wants to select some text in the link and bold it.

@fredck
Copy link
Contributor

fredck commented Sep 12, 2016

Hum... I still have the sensation that the panel should appear in such case. After all, the panel doesn't block other features to be executed over the selection, right?

@oleq
Copy link
Member Author

oleq commented Sep 12, 2016

@fredck ATM I'm thinking about slightly different approach to opening the panel with mouse/keyboard because the problem is bigger, in fact. I'll submit it as another issue ASAP.

@oleq
Copy link
Member Author

oleq commented Sep 12, 2016

@fredck I described the problem in https://github.com/ckeditor/ckeditor5-link/issues/26 (RFC!). If we drop "focus stealing" behaviour for mouse interactions, then we could always display the panel – for collapsed, non–collapsed, partial, and full selection in editable.

@oskarwrobel oskarwrobel removed their assignment Sep 12, 2016
@Reinmar
Copy link
Member

Reinmar commented Sep 22, 2016

I see that we agreed on ckeditor/ckeditor5-link#26 (I'm reviewing it now and it works great), so I assume that this issue is confirmed and we can open the balloon when entire link is selected (I agree with @fredck that this is expected behaviour).

@Reinmar
Copy link
Member

Reinmar commented May 10, 2017

Can we have this fixed? It may sometimes (#116) be really confusing.

@oleq oleq self-assigned this May 15, 2017
oleq referenced this issue in ckeditor/ckeditor5-link May 16, 2017
oskarwrobel referenced this issue in ckeditor/ckeditor5-link May 17, 2017
Fix: The editing UI should show up when the selection encloses a link. Closes #23.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants