Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+K should open link URL editing dialog #4825

Closed
Reinmar opened this issue Mar 11, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-link#190
Closed

Ctrl+K should open link URL editing dialog #4825

Reinmar opened this issue Mar 11, 2018 · 3 comments · Fixed by ckeditor/ckeditor5-link#190
Assignees
Labels
package:link status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Mar 11, 2018

  1. http://localhost:8125/ckeditor5-core/tests/manual/article.html
  2. Click the link. Link balloon appears.
  3. Press Ctrl+K.

Expected: something could happen.

Actually: nothing happens.


Another scenario:

  1. http://localhost:8125/ckeditor5-core/tests/manual/article.html
  2. Click next to the link. Press arrow keys to navigate into the link.
  3. Press Ctrl+K.
  4. The link balloon appears.

How to start editing the link now? You need to Tab to the "edit link" button and press Enter.


I think that both these cases would benefit if Ctrl+K press when the link balloon is visible, would switch to the link URL editing balloon.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 11, 2018

cc @oleq @dkonopka

@dkonopka
Copy link
Contributor

dkonopka commented Mar 12, 2018

Agree that first scenario should open editing balloon (if it's opened), but TBH I'm not sure to turn on this step in the second scenario (what if someone wants to open link in the new tab instead of editing it? Users needs to go "check" button, it's not so intuitive. )

On the other hand, would be great if the behavior of shortcut Ctrl+K will be always the same.

@Reinmar
Copy link
Member Author

Reinmar commented Mar 12, 2018

(what if someone wants to open link in the new tab instead of editing it? Users needs to go "check" button, it's not so intuitive. )

The link balloon will be visible too:

I think that both these cases would benefit if Ctrl+K press when the link balloon is visible, would switch to the link URL editing balloon.

So, there will be two steps always:

  • First you need to see the link balloon (by clicking on a link or by pressing ctrl+k).
  • And then you can go to the link editing ballooon (by clicking "edit" in the first balloon or by pressing ctrl+k again).

oleq referenced this issue in ckeditor/ckeditor5-link Apr 4, 2018
@oleq oleq self-assigned this Apr 4, 2018
dkonopka referenced this issue in ckeditor/ckeditor5-link Apr 5, 2018
Feature: The Ctrl+K keystroke should open link URL editing dialog. Closes #181.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 15 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:improvement This issue reports a possible enhancement of an existing feature. package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link status:discussion type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants