Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link feature is creating empty text nodes with linkHref attribute #4821

Closed
scofalik opened this issue Feb 21, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-link#170
Closed

Link feature is creating empty text nodes with linkHref attribute #4821

scofalik opened this issue Feb 21, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-link#170
Assignees
@scofalik
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 14

Comments

@scofalik
Copy link
Contributor

As in the title: when selection is collapsed, opening link balloon and saving the link will create an empty text node with linkHref attribute. It leads to errors like: #787, probably #788

Also when you move caret and put it back at the "empty" link, the balloon toolbar will appear.
@scofalik scofalik self-assigned this Feb 21, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-link Feb 26, 2018
@Reinmar
Merge pull request #170 from ckeditor/t/169
0641978 
Fix: Link feature was creating empty text nodes with `linkHref` attribute. Closes #169.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 14
Development

Successfully merging a pull request may close this issue.

Link feature was creating empty text nodes with linkHref attribute ckeditor/ckeditor5-link
2 participants
@scofalik @mlewand