Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FF] Browser steals selection on CLTR+K #4811

Closed
scofalik opened this issue Oct 2, 2017 · 5 comments · Fixed by ckeditor/ckeditor5-link#155
Closed

[FF] Browser steals selection on CLTR+K #4811

scofalik opened this issue Oct 2, 2017 · 5 comments · Fixed by ckeditor/ckeditor5-link#155
Assignees
@ma2ciek
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 12

Comments

@scofalik
Copy link
Contributor

scofalik commented Oct 2, 2017

Steps to reproduce

  1. Open a sample, for example: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/examples/builds/balloon-editor.html
  2. Select some text.
  3. Press Ctrl + K to open link balloon.

Expected result

Field in balloon is focused.

Current result

Browser steals selection and focuses in search bar.

Notes

I think this is because we cannot cancel default event.
@Reinmar
Copy link
Member

Reinmar commented Oct 2, 2017

Strange that it doesn't work. I don't recall problems with handling this keystroke.

@fredck
Copy link
Contributor

fredck commented Oct 2, 2017

I think this is because we cannot cancel default event.

This works well in GDocs and Medium, so it should be doable to control these keys.

@Reinmar
Copy link
Member

Reinmar commented Oct 2, 2017

If we'll have anyone able to look into this, we may squeeze it into it12. @ma2ciek, could you check it?

@scofalik
Copy link
Contributor Author

scofalik commented Oct 2, 2017 •
edited
Loading

@fredck Of course, we already had similar issue with Tab that is used in List feature.

@Reinmar
Copy link
Member

Reinmar commented Oct 2, 2017

Wasn't the issue with lists different? Wasn't it caused by two features not being able to decide which should handle Tab?

@ma2ciek ma2ciek self-assigned this Oct 2, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-link Oct 2, 2017
@Reinmar
Merge pull request #155 from ckeditor/t/153
5360fce 
Fix: Prevented default browser actions on <kbd>Ctrl</kbd>+<kbd>K</kbd> (which should move focus to "URL" input in the link balloon. Closes #153. Closes #154.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@ma2ciek ma2ciek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ma2ciek ma2ciek

Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Prevent default browser actions on CTRL+K ckeditor/ckeditor5-link
5 participants
@Reinmar @fredck @scofalik @ma2ciek @mlewand