Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkBalloonPanel should be displayed in read-only mode when Link/Unlink commands are disabled #4800

Closed
oskarwrobel opened this issue Jul 6, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-link#136
Closed

LinkBalloonPanel should be displayed in read-only mode when Link/Unlink commands are disabled #4800

oskarwrobel opened this issue Jul 6, 2017 · 2 comments · Fixed by ckeditor/ckeditor5-link#136
Assignees
@oskarwrobel
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@oskarwrobel
Copy link
Contributor

Balloon should be displayed but modifying the link element should be not possible.
Input should be read-only, Unlink and Submit buttons should be disabled.
@oleq
Copy link
Member

oleq commented Jul 6, 2017

IMO you should not be able to open the panel when the command is disabled. See ckeditor/ckeditor5-link#133.

@oskarwrobel
Copy link
Contributor Author

You should by clicking on the link element. This is needed by #492.

@oskarwrobel oskarwrobel self-assigned this Jul 6, 2017
oleq referenced this issue in ckeditor/ckeditor5-link Jul 13, 2017
@oleq
Merge pull request #136 from ckeditor/t/135
50da835 
Feature: `LinkFormView` controls should enter the read-only mode when `LinkCommand` and `UnlinkCommand` are disabled. Closes #135.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added domain:ui/ux This issue reports a problem related to UI or UX. status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:link labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
3 participants
@oskarwrobel @oleq @mlewand