Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'undefined' is displayed in the link URL's input #4793

Closed
Reinmar opened this issue May 19, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-link#124
Closed

'undefined' is displayed in the link URL's input #4793

Reinmar opened this issue May 19, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-link#124
Assignees
@oleq
Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@Reinmar
Copy link
Member

Reinmar commented May 19, 2017

When opening the balloon on not a link the input's value is set to undefined.
@Reinmar
Copy link
Member Author

Reinmar commented May 19, 2017

Integration tests are missing if such regressions appear.

oleq referenced this issue in ckeditor/ckeditor5-link May 19, 2017
@oleq
Fix: URL input value should not be 'undefined' when no link is select…
38b0b1b 
…ed. Closes #123.
@oleq oleq self-assigned this May 19, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-link May 19, 2017
@Reinmar
Merge pull request #124 from ckeditor/t/123
22893d3 
Fix: URL input value should not be `'undefined'` when no link is selected. Closes #123.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
@mmichaelis mmichaelis mentioned this issue Jun 17, 2021
Open
mmichaelis added a commit to CoreMedia/ckeditor-plugins that referenced this issue Jun 17, 2021
@mmichaelis
fix(link-plugin): Clear Target And Behavior on Reopening Form View
c81a36b 
Similar to `LinkUI` from CKEditor's Link Feature we must ensure, that
target input field and behavior selector are reset each time the form
view is opened.

The previous approach only covered the use-case of doing so from action
view by listening to edit-button. But, this neither deals with Ctrl+K
keystroke nor with toolbar action.

The only feasible workaround we found, was adding a decorator to the
private method `LinkUI#_addFormView`, and thus refers to missing
extension points as reported at ckeditor/ckeditor5#9730.

See-also: ckeditor/ckeditor5#4765
See-also: ckeditor/ckeditor5#4793
See-also: ckeditor/ckeditor5#9730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:link type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/123: URL input value should not be 'undefined' when no link is selected ckeditor/ckeditor5-link
3 participants
@Reinmar @oleq @mlewand