Merge pull request #115 from ckeditor/t/109

Feature: URL input field should provide a placeholder. Closes #109.
ckeditor · May 11, 2017 · 6d18c55 · 6d18c55
2 parents 2de1674 + 31ac147
commit 6d18c55
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/ui/linkformview.js b/src/ui/linkformview.js
@@ -199,6 +199,7 @@ export default class LinkFormView extends View {
 		const labeledInput = new LabeledInputView( this.locale, InputTextView );
 
 		labeledInput.label = t( 'Link URL' );
+		labeledInput.inputView.placeholder = t( 'http://example.com' );
 
 		return labeledInput;
 	}

diff --git a/tests/ui/linkformview.js b/tests/ui/linkformview.js
@@ -18,7 +18,7 @@ describe( 'LinkFormView', () => {
 	let view;
 
 	beforeEach( () => {
-		view = new LinkFormView( { t: () => {} } );
+		view = new LinkFormView( { t: ( val ) => val } );
 
 		return view.init();
 	} );
@@ -97,6 +97,12 @@ describe( 'LinkFormView', () => {
 			expect( spy.calledOnce ).to.true;
 		} );
 
+		describe( 'url input view', () => {
+			it( 'has placeholder', () => {
+				expect( view.urlInputView.inputView.placeholder ).to.equal( 'http://example.com' );
+			} );
+		} );
+
 		describe( 'template', () => {
 			it( 'has url input view', () => {
 				expect( view.template.children.get( 0 ) ).to.equal( view.urlInputView );