Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Default action of Enter and ShiftEnter should be always prevented #56

Merged
merged 2 commits into from
Sep 4, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Jul 5, 2018

Suggested merge commit message (convention)

Fix: Default action of Enter event should be always prevented. Closes ckeditor/ckeditor5#1120.

@pomek pomek requested a review from Reinmar July 5, 2018 07:07
@pomek
Copy link
Member Author

pomek commented Jul 5, 2018

I tried to write an integration test in image package but it always passed...

I wanted to fire the enter event on view.document. Was it a correct way?

@coveralls
Copy link

coveralls commented Jul 5, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 4ae6a99 on t/ckeditor5/1120 into facc882 on master.

@pomek pomek changed the title Default action of Enter and ShiftEnter should be always prevent Default action of Enter and ShiftEnter should be always prevented Jul 5, 2018
@Reinmar
Copy link
Member

Reinmar commented Jul 5, 2018

I wanted to fire the enter event on view.document. Was it a correct way?

Yes.

@pomek
Copy link
Member Author

pomek commented Jul 5, 2018

The tests are here - ckeditor/ckeditor5-image#218

But as I said, I am not sure about them.

@Reinmar
Copy link
Member

Reinmar commented Jul 5, 2018

You wrote that they always passed. That indeed makes them invalid. I'll look into this.

@Reinmar
Copy link
Member

Reinmar commented Sep 4, 2018

OK, I realised now that you're talking about the integration tests. They indeed check a different thing. I'll comment that in that other PR.

@Reinmar Reinmar merged commit 8d7c75f into master Sep 4, 2018
@Reinmar Reinmar deleted the t/ckeditor5/1120 branch September 4, 2018 15:37
@Reinmar
Copy link
Member

Reinmar commented Sep 4, 2018

I merged this PR because itself it's correct.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants