This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/1226 Refactored how markers removal is converted from the model to the view #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR ckeditor/ckeditor5-link#178 |
scofalik
changed the title
pjasiun
reviewed
Mar 14, 2018
src/view/writer.js
Outdated
| * @returns {Set.<module:engine/view/attributeelement~AttributeElement>|null} Set containing all the attribute elements | ||
| * with the same `id` or `null` if given element had no `id`. | ||
| */ | ||
| getAllClonedElements( element ) { |
There was a problem hiding this comment.
The getter should not be a writer method. It should be a method of an element. You should not require creating view.change block to call getter, because this block causes rendering.
pjasiun
reviewed
Mar 16, 2018
src/conversion/mapper.js
Outdated
|
|
||
| for ( const element of boundElements ) { | ||
| if ( element.is( 'attributeElement' ) ) { | ||
| for ( const clone of element.getCustomProperty( 'clonedElements' ) ) { |
There was a problem hiding this comment.
Shouldn't getAllClonedElements be used here?
pjasiun
reviewed
Mar 16, 2018
src/view/writer.js
Outdated
| } | ||
|
|
||
| group.add( element ); | ||
| this.setCustomProperty( 'clonedElements', group, element ); |
There was a problem hiding this comment.
I would use a protected property instread of a custom property.
…are broken during wrapping. Introduced `view.Writer#getAllBrokenSiblings`. Changed: Changed how `view.Writer` wraps and unwraps elements, now it bases on `view.AttributeElement#id` too. Removed: Removed `HighlightAttributeElement`.
…roller` to `conversion.DowncastDispatcher`. Changed: Use markers binding provided by `conversion.Mapper` in `conversion.downcast-converters`.
…s groups and how `conversion.Mapper` uses this information.
pjasiun
reviewed
Mar 16, 2018
src/view/attributeelement.js
Outdated
| */ | ||
| get priority() { | ||
| return this._priority; | ||
| } | ||
|
|
||
| /** | ||
| * Element identifier. If set, it is used by {@link module:engine/view/element~Element#isSimilar}, | ||
| * and then two elements are considered similar if, and only if they have the same `_id`. |
pjasiun
reviewed
Mar 16, 2018
src/view/attributeelement.js
Outdated
| * Throws {@link module:utils/ckeditorerror~CKEditorError attribute-element-get-elements-with-same-id-no-id} | ||
| * if this element has no `id`. | ||
| * | ||
| * @returns {Set.<module:engine/view/attributeelement~AttributeElement>|null} Set containing all the attribute elements |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Refactored how markers removal is converted from the model to the view. Closes ckeditor/ckeditor5#4233.