Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More cases of affected markers on merging in writer #4516

Closed
scofalik opened this issue May 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1739
Closed

More cases of affected markers on merging in writer #4516

scofalik opened this issue May 19, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1739
Assignees
@scofalik
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 24

Comments

@scofalik
Copy link
Contributor

At the moment, we have a mechanism that creates additional MarkerOperations if a marker gets affected by writer.merge() in a way that would cause the marker to be incorrectly restored on undo. Some cases were missed in the initial implementation.
@scofalik scofalik self-assigned this May 19, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-engine May 20, 2019
Merge pull request #1739 from ckeditor/t/1738
01ff6e6 
Other: Added more cases of affected markers on merging in `model.Writer`. Closes #1738.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 24 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 24
Development

Successfully merging a pull request may close this issue.

Added more cases of affected markers on merging in writer ckeditor/ckeditor5-engine
2 participants
@scofalik @mlewand