Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fake selection throws when pressing backspace while the delete command is disabled #4501

Closed
oskarwrobel opened this issue Apr 1, 2019 · 0 comments
Closed

Fake selection throws when pressing backspace while the delete command is disabled #4501

oskarwrobel opened this issue Apr 1, 2019 · 0 comments
Assignees
@oskarwrobel
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 23

Comments

@oskarwrobel
Copy link
Contributor

When the selection is on the widget (like Image) then the dom selection is inside a fake selection container. Also, there is a label inside FSC for the screen readers purpose.

The problem is when the typing plugin is disabled, then pressing keys does not change the editable but it changes the content of the FSC. Code which manages FSC does not handle it properly.
@oskarwrobel oskarwrobel self-assigned this Apr 1, 2019
@oskarwrobel oskarwrobel changed the title Fake selection throws when pressing backspace in read-only mode Fake selection throws when pressing backspace while the delete command is disabled Apr 1, 2019
pjasiun referenced this issue in ckeditor/ckeditor5-engine Apr 1, 2019
Merge pull request #1715 from ckeditor/t/1714
c48f5a4 
Fix: Prevent from throwing while updating empty fake selection container. Closes #1714.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 23 milestone Oct 9, 2019
@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 23
Development

No branches or pull requests
2 participants
@oskarwrobel @mlewand