Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block filler must be rendered in empty lines created by <br> #4351

Closed
Reinmar opened this issue May 30, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1426
Closed

Block filler must be rendered in empty lines created by <br> #4351

Reinmar opened this issue May 30, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1426
Assignees
@pomek
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 18

Comments

@Reinmar
Copy link
Member

Reinmar commented May 30, 2018

may-30-2018 11-51-21

Unfortunately, we must achieve this when rendering a block which ends with a line break:

<p>...<br>BLOCK_FILLER</p>

BLOCK_FILLER is a <br data-cke-filler=true> inside the editing view and &nbsp; in the data.

So, we need to adjust the logic which decides where to place block fillers. In general, block filler is needed after a <br> if that <br> is the last node of a container element:

<p>XXX<br>YYY<br>ZZZ<br>BLOCK_FILLER</p>
<p>XXX<br>YYY<br>ZZZ<br>ĄŚĆ</p>
<p><br>YYY<br>ZZZ<br>ĄŚĆ</p>
Reinmar referenced this issue in ckeditor/ckeditor5-engine Jun 7, 2018
@Reinmar
Merge pull request #1426 from ckeditor/t/1422
ba3d641 
Fix: Block filler will be inserted into the container if its last child is a `<br>` element. Closes #1422.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added module:view type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@pomek pomek mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 18
Development

Successfully merging a pull request may close this issue.

Render block filler in empty lines in container ckeditor/ckeditor5-engine
3 participants
@Reinmar @pomek @mlewand