Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect selection after reaching the side image with the caption #4204

Closed
Mgsy opened this issue Oct 31, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1431
Closed

Incorrect selection after reaching the side image with the caption #4204

Mgsy opened this issue Oct 31, 2017 · 3 comments · Fixed by ckeditor/ckeditor5-engine#1431
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 18

Comments

@Mgsy
Copy link
Member

Mgsy commented Oct 31, 2017

We have few cases with the incorrect selection, when it starts in the block element which is below the side image with the caption.

Chrome

Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Start the selection in the block quote.
  3. Move it to the image, but do it really slowly. You have to move the selection to the beginning of the image (you can reach just the left border - see at the gif below).

Current result

The selection moves to the beginning of the document.

GIF

bug_cke5
@Mgsy
Copy link
Member Author

Mgsy commented Oct 31, 2017

Chrome

Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Start the selection in the block quote.
  3. Move it to the image.

Current result

The selection disappears.

GIF

bug_cke5

Related - #531.

@Mgsy
Copy link
Member Author

Mgsy commented Oct 31, 2017

Safari

Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Start the selection in the block quote.
  3. Move it to the image.

Current result

Content above the image has been selected.

GIF

bug_cke5

@Mgsy Mgsy changed the title [Chrome/Safari] Incorrect selection after reaching the side image with the caption Incorrect selection after reaching the side image with the caption Oct 31, 2017
@Mgsy
Copy link
Member Author

Mgsy commented Oct 31, 2017

Edge

Steps to reproduce

  1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
  2. Put the caret near the image at the height of the first Quote in the block quote.
  3. Double click.
  4. Type something.

Current result

Empty block has been inserted above the block quote. After step 4, the selection moves upwards.

GIF

bug_cke5

Reinmar referenced this issue in ckeditor/ckeditor5-engine Jun 18, 2018
@Reinmar
Merge pull request #1431 from ckeditor/t/ckeditor5-table/12
6cf91a1 
Feature: Introduced a selection post-fixer. Its role is to ensure that after all changes are applied the selection is placed in a correct position. Closes #1156. Closes #1176. Closes #1182. Closes ckeditor/ckeditor5-table#11. Closes ckeditor/ckeditor5-table#12. Closes ckeditor/ckeditor5-table#15. Closes ckeditor/ckeditor5#562. Closes ckeditor/ckeditor5#611.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added module:selection type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 18
Development

Successfully merging a pull request may close this issue.

Introduce selection post-fixer ckeditor/ckeditor5-engine
2 participants
@mlewand @Mgsy