Merge pull request #1798 from Sebobo/t/1797

Feature: Added support for creating elements from other XML namespaces. See ckeditor/ckeditor5#2088.
ckeditor · Oct 8, 2019 · a9190c9 · a9190c9
2 parents 45c82be + 1f2d981
commit a9190c9
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/view/domconverter.js b/src/view/domconverter.js
@@ -224,7 +224,11 @@ export default class DomConverter {
 				return domElement;
 			} else {
 				// Create DOM element.
-				domElement = domDocument.createElement( viewNode.name );
+				if ( viewNode.hasAttribute( 'xmlns' ) ) {
+					domElement = domDocument.createElementNS( viewNode.getAttribute( 'xmlns' ), viewNode.name );
+				} else {
+					domElement = domDocument.createElement( viewNode.name );
+				}
 
 				if ( options.bind ) {
 					this.bindElements( domElement, viewNode );

diff --git a/tests/view/domconverter/view-to-dom.js b/tests/view/domconverter/view-to-dom.js
@@ -174,6 +174,15 @@ describe( 'DomConverter', () => {
 			expect( domTextNode.data ).to.equal( 'foo' );
 		} );
 
+		it( 'should create namespaced elements', () => {
+			const namespace = 'http://www.w3.org/2000/svg';
+			const viewSvg = new ViewElement( 'svg', { xmlns: namespace } );
+
+			const domSvg = converter.viewToDom( viewSvg, document );
+
+			expect( domSvg.createSVGRect ).to.be.a( 'function' );
+		} );
+
 		describe( 'it should convert spaces to &nbsp;', () => {
 			it( 'at the beginning of each container element', () => {
 				const viewDiv = new ViewContainerElement( 'div', null, [