Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable should get attributes of the element which is replaced #2213

Closed
Reinmar opened this issue Oct 7, 2016 · 5 comments
Closed

Editable should get attributes of the element which is replaced #2213

Reinmar opened this issue Oct 7, 2016 · 5 comments
Labels
package:editor-classic resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@Reinmar
Copy link
Member

Reinmar commented Oct 7, 2016

This came in https://github.com/ckeditor/ckeditor5-engine/issues/543. I added dir=rtl to the element the editor was replacing and I was expecting that the editable will have the same attribute.

OTOH, not all attributes can be copied. Styles, ids, etc, perhaps should be copied.

@fredck
Copy link
Contributor

fredck commented Oct 7, 2016

I'm wondering if we do anything like this in CKEditor 4.

@Reinmar
Copy link
Member Author

Reinmar commented Oct 7, 2016

I remember that we do something with dir, but I don't know what precisely. Either it's taken from the config or from the original element. But this made me think that config could be a better place... unless someone also wants to set couple of other attributes like e.g. content language (which can matter as well – e.g. for spellchecker).

@Reinmar
Copy link
Member Author

Reinmar commented Apr 5, 2018

The more I think about this... the more unsure I am how this should work. Inheriting classes may break the editor, id can't be inherited at all. There may be more such attributes. So, we should either:

  • whitelist what makes sense to be inherited,
  • allow passing these attrs in the config – this may be preferred (e.g. one may want to assign a specific class to the editable so the content inside is styled using some special styles).

PS. There's also #798.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-editor-classic Oct 8, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:editor-classic labels Oct 8, 2019
@mlewand mlewand added this to the backlog milestone Oct 8, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:editor-classic resolution:expired This issue was closed due to lack of feedback. status:stale type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

5 participants