Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default theme: spacing and sizes #116

Closed
oleq opened this issue Feb 1, 2016 · 5 comments
Closed

Default theme: spacing and sizes #116

oleq opened this issue Feb 1, 2016 · 5 comments

Comments

@oleq
Copy link
Member

oleq commented Feb 1, 2016

  • Is the default theme well designed in terms of space management?
    • Gaps between toolbar buttons.
    • Gaps between buttons and toolbar boundaries.
    • Control positioning in dialogs.
    • Size and spacing in menus (dropdowns).

image

  • Does reduced spacing affect UX? What kind of impact would it have in reality?
    • Is this necessary?
    • Are the icons too big?

image

@Reinmar
Copy link
Member

Reinmar commented Feb 1, 2016

I prefer reduced spacing. That's partly because of my personal preference (it simply looks better) and also because the space on the screen is expensive. You cannot take too much of it, because it leaves less space for editing and other components.

However, enough spacing is also important for readability and accessibility purposes, so we cannot go too low. I think that the second toolbar which you proposed finds the golden mean in this case. So I'm definitely for it.

@oleq
Copy link
Member Author

oleq commented Feb 1, 2016

However, enough spacing is also important for readability and accessibility purposes, so we cannot go too low. I think that the second toolbar which you proposed finds the golden mean in this case. So I'm definitely for it.

TBH, I'm against limited gaps and spacing because it results in a lots–of–everyting effect, which is pretty confusing to the users. I'd rather seize the opportunity which is offered by #95 – reduce number of buttons and leave space around them. Less clutter, more clarity.

@koleary
Copy link

koleary commented Feb 18, 2016

Big improvement over current default toolbar.

I like the second one, I do not think the tighter spacing impairs legibility for normally-sighted users. Others can zoom. The icon color may not pass WCAG though.

@fredck
Copy link
Contributor

fredck commented Feb 22, 2016

+1 for the 2nd option as well. The less UI, the better, at lest for the generic default UI we want to propose.

@Reinmar
Copy link
Member

Reinmar commented Apr 20, 2018

Cleaning up old discussions. See #186.

@Reinmar Reinmar closed this as completed Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants