-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default theme: icon colors #107
Comments
What about 3-colors? White and black with details in additional color, for example red, by default. It would be great if that color would be configurable, but it may be hard to implement. This way editor could better fit webpage. I general it is the pros of monochromatic iconset, I believe they better fit random webpage which integrates CKEditor. |
@pjasiun Sounds great but that would only be possible if we used SVG inline (https://css-tricks.com/cascading-svg-fill-color/, http://stackoverflow.com/questions/13367868/modify-svg-fill-color-when-being-served-as-background-image), which is unlikely TBH. |
Or (maybe) we could use png, with transparency, and change the background color, couldn't we? |
Or produce SVG icons generator ;) Kinda like LESS. |
There is also one more option: custom icon font, which color can be easily made configurable. Choosing icon font enables us also to use nice features – ligatures, that could improve accessibility of icons de facto out of box. |
Coincidentally, some useful discussion on icons happened on GitHub related to JQuery Chassis (another GitHub section I am following): jquery-archive/css-chassis#1 They decided on SVG for the flexibility... +1 to Reinmar I hate monochromatic icons. We are not dogs. Humans have cones for colors in their eyes... should make use of them. :-D Color communicates additional information. I am currently using the FontAwesome iconic font. I thought it would be a slam dunk to use, but I have run into the occasional issue with corporate and government users that have downloadable web fonts blocked by their IT departments. I am going to still use FontAwesome (until JQ Chassis is released) but keep in mind that downloads of web fonts can be blocked. |
Note: Moved discussion about icon types to #109. Let's focus on visual appearance in this issue only.
Please note that CKEditor is integrated into numerous environments (web pages, applications, some of them quite exotic). It is our goal to make default theme as flexible as possible, so it visually works out–of–the–box for as many integrations as possible. Something like jeans and t–shirt – |
I agree with @oleq and I'm for a monochromatic solution. The editor UI is not there to enhance the overall application style... it must be neutral instead. Additionally, there must be a reason why this is a tendency out there. |
Have you looked at number of CKE4 builds w/ mono vs color themes for some perspective? |
definietly monochromoatic. It is way more accessible for some people. At the same time I like the idea behind 3 color icons, mentioned by @pjasiun - it could be done with e.g. icon font and EDIT: it is called 'stack icons' - thanks @oleq for link to the other issue with a mention about it. |
@ofcapl Take a look on #109. |
Color doesn't mean that it has to be a full rainbow in each icon, it can be something like the 3 colors proposal by @pjasiun , something that really helps the users to quickly find each icon instead of having to hunt them around everytime. Look at the real life, signs have colors, everything has colors and help us to find and locate them, but we don't like when anyone flashes a light on our face. |
@AlfonsoML: Agree completely with you... +1 for 3-color icon option by @pjasiun ... excellent compromise! |
Other than some funky effect, I don't think that "one" additional color adds a lot in terms of helping understanding or locating icons. It is true that the use of color in signs is useful but in those cases the color has a precise meaning and effectively participate on the sign meaning (e.g. red = no; green = yes). If the point is just making the icons stand out, still a monochromatic solution fits. One can make icons flashing red instead of dark gray it that's the whole point about it. A mono configurable solution seems to be enough. |
I agree with Fred. Either multicolor icons or monochromatic. Intermediate solutions will only make things a lot harder to code without giving much better results. |
@AlfonsoML This is something we'd like to avoid. Take a look on #95. Anyway, take a look on Google Docs, it's all mono: But icons may get custom color when necessary, i.e. to announce the state of the feature: It makes sense to me. BTW, it surprised me that Google Docs uses PNG sprites (instead of SVG or icon fonts) – #109. |
I think this is a discussion that will always have some proponents on either side. Suffice to say, that there will probably be some that will favor mono icons and there will be some that will favor color icons. |
There may be people who prefer color icons from an aesthetic point of view but usability is what's important and from that perspective it becomes more difficult—and less effective—to apply "semantic" color (eg. red for a destructive action) selectively if the icons already have color. |
+1 for monochromatic icons. I agree with @oleq that some colour where applicable (font colour) would lift the interface and offer good feedback. Have you considered using the material design icon set at https://design.google.com/icons/? |
Why not to use a font for icons, like this one?: In this way, you can change the color and size of the icons using CSS, so it's easy to adapt to the application look & feel. |
The discussion about SVG vs fonts was held in #109. |
Cleaning up old discussions. See #186. |
Note: Discussion about icon types (SVG vs icons fonts) in #109.
Default theme may come with:
Which option is the best?
Related tickets:
The text was updated successfully, but these errors were encountered: