Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce EditorUI#update event #2890

Closed
oskarwrobel opened this issue Jun 25, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-core#131
Closed

Introduce EditorUI#update event #2890

oskarwrobel opened this issue Jun 25, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-core#131
Assignees
@oskarwrobel
Labels
package:core type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 19

Comments

@oskarwrobel
Copy link
Contributor

Now we use view#render event to attach and reposition floating UI stuff. The problem is that rendered layout should not be the only reposition trigger. We are going to introduce ViewDocument#layoutChanged event https://github.com/ckeditor/ckeditor5-engine/issues/1445 so we will have another trigger soon. Besides, we should make it possible to trigger UI refresh manually without touching the engine part.

We decided to introduced one EditorUI#update event. This event should be fired every time when editor UI should be refreshed (after all document layout changes). All UI part of the plugins should listen to this event instead of view#render.

Related stuff:
@oskarwrobel oskarwrobel self-assigned this Jun 25, 2018
oleq referenced this issue in ckeditor/ckeditor5-core Jun 29, 2018
@oleq
Merge pull request #131 from ckeditor/t/130
734166a 
Feature: Introduced the `EditorUI#update` event. Closes #130.

BREAKING CHANGE: The `EditorUI` is now a class (no longer an interface).
oleq referenced this issue in ckeditor/ckeditor5-editor-classic Jun 29, 2018
@oleq
Merge pull request #74 from ckeditor/t/ckeditor5-core/130
ae98cfd 
Other: Used the `EditorUI` as a parent class for the `ClassicEditorUI` (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-editor-inline Jun 29, 2018
@oleq
Merge pull request #40 from ckeditor/t/ckeditor5-core/130
c148346 
Other: Used the `EditorUI` as a parent class for the `InlineEditorUI` (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-editor-balloon Jun 29, 2018
@oleq
Merge pull request #21 from ckeditor/t/ckeditor5-core/130
03af1c0 
Other: Used the `EditorUI` as a parent class for the `BalloonEditorUI` (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-editor-decoupled Jun 29, 2018
@oleq
Merge pull request #16 from ckeditor/t/ckeditor5-core/130
d92da9f 
Other: Used the `EditorUI` as a parent class for the `DecoupledEditorUI` (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-link Jun 29, 2018
@oleq
Merge pull request #197 from ckeditor/t/ckeditor5-core/130
ee87c63 
Internal: Used the `EditorUI#update` event instead of `View#render` to attach the UI components (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-table Jun 29, 2018
@oleq
Merge pull request #78 from ckeditor/t/ckeditor5-core/130
b0991f4 
Internal: Used the `EditorUI#update` event instead of `View#render` to attach the UI components (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-ui Jun 29, 2018
@oleq
Merge pull request #416 from ckeditor/t/ckeditor5-core/130
0ed2b79 
Internal: Used the `EditorUI#update` event instead of `View#render` to attach the UI components (see ckeditor/ckeditor5-core#130).
oleq referenced this issue in ckeditor/ckeditor5-image Jun 29, 2018
@oleq
Merge pull request #215 from ckeditor/t/142
dee20c0 
Fix: The UI should update once the image is loaded. Closes #142. 

Used the `EditorUI#update` event instead of `View#render` to attach the UI components (see ckeditor/ckeditor5-core#130).
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:core labels Oct 9, 2019
@oskarwrobel oskarwrobel mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskarwrobel oskarwrobel

Labels
package:core type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 19
Development

Successfully merging a pull request may close this issue.

Introduced EditorUI#update event ckeditor/ckeditor5-core
2 participants
@oskarwrobel @mlewand