Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #98

Closed
Dumluregn opened this issue Mar 19, 2020 · 3 comments · Fixed by #124
Closed

Bump dependencies #98

Dumluregn opened this issue Mar 19, 2020 · 3 comments · Fixed by #124
Assignees
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone

Comments

@Dumluregn
Copy link
Collaborator

Are you reporting a feature request or a bug?

Task

Provide detailed reproduction steps (if any)

dependencies
devDependencies

The second one is not as important as the main deps.

@Dumluregn Dumluregn added task status:confirmed An issue confirmed by the development team. labels Mar 19, 2020
@ezintz
Copy link
Contributor

ezintz commented Apr 11, 2020

Hello, I have been doing this in my fork. Everything is still working, but my changes for additional common events are included. I will wait until that one is merged to open another pull request.

Would it make sense to have different releases for different Angular versions? I was thinking about to go with Angular versions e.g. 9.x.x or 8.x.x for previous version.

@f1ames
Copy link
Contributor

f1ames commented Apr 14, 2020

Hello @ezintz,

dependencies of ckeditor4-angular package are rather minimal - only load-script and tslib (see on NPM) so I'm not sure if there is any sense in having different releases for different Angular versions. Do yo think there could be any issue with newer/older Angular versions with those deps?

@f1ames f1ames added type:task Any other issue (refactoring, typo fix, etc). and removed task labels Jun 22, 2020
@f1ames
Copy link
Contributor

f1ames commented Jun 25, 2020

As for devDependencies we have an issue with @angular-devkit/build-angular dependency which requires [email protected] and so we cannot build docs (ckeditor4-docs) with never than 10 version of node (because it is used there too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants