Do not skip pre-install commands when --install-only is passed #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjolowicz
changed the title
cjolowicz
force-pushed
the
run-always
branch
2 times, most recently
from
97be416
to
7eb2799
Compare
The `session.run_always` method is only available in 2020.8.22 and later. Also, avoid the `^` version operator. It implies `< 2021`, preventing installation of nox-poetry with any new Nox release.
This was referenced Mar 14, 2021
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use session.run_always to ensure the following commands are still run when
--install-onlyis passed to Nox:poetry export)poetry build)pip uninstall)nox-poetry now requires Nox 2020.8.22 or later, because the
session.run_alwaysmethod is not available in earlier versions.Also, this PR fixes the Nox version constraint. The
^2020.5.24constraint implies< 2021, preventing installation of nox-poetry with any Nox release newer than 2020.