Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt OPAL_LOAD_PATH env variable to webpack standards #7

Open
wied03 opened this issue Apr 7, 2016 · 2 comments
Open

Adapt OPAL_LOAD_PATH env variable to webpack standards #7

wied03 opened this issue Apr 7, 2016 · 2 comments

Comments

@wied03
Copy link
Collaborator

wied03 commented Apr 7, 2016

Lower priority.

Rather than have a separate OPAL_LOAD_PATH setting, might want to use resolve.moduleDirectories in the webpack config instead. This is changing with webpack 2.0 though, so probably best to wait until that happens.

When this is done, look into removing absolute paths from the webpack requires. Those make it into the cache and we don't want to make the cache dirty just because directories are moved around.

@wied03 wied03 changed the title Change load path Migrate OPAL_LOAD_PATH env variable into webpack standards Apr 7, 2016
@wied03 wied03 mentioned this issue Apr 9, 2016
13 tasks
@wied03 wied03 added this to the 0.11.0 milestone Apr 11, 2016
@wied03 wied03 changed the title Migrate OPAL_LOAD_PATH env variable into webpack standards Adapt OPAL_LOAD_PATH env variable to webpack standards Apr 13, 2016
@wied03
Copy link
Collaborator Author

wied03 commented Apr 24, 2016

In Webpack 2.0, resolve.root, resolve.moduleDirectories, and resolve.fallback => resolve.modules.

@wied03
Copy link
Collaborator Author

wied03 commented Apr 25, 2016

One issue with implementing this is that loaders really shouldn't modify the webpack config. That should be a plugin's job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant