diff --git a/CRM/Upgrade/Incremental/php/FiveFiftySeven.php b/CRM/Upgrade/Incremental/php/FiveFiftySeven.php index 06977c0000a4..cc58cfbce549 100644 --- a/CRM/Upgrade/Incremental/php/FiveFiftySeven.php +++ b/CRM/Upgrade/Incremental/php/FiveFiftySeven.php @@ -21,11 +21,24 @@ */ class CRM_Upgrade_Incremental_php_FiveFiftySeven extends CRM_Upgrade_Incremental_Base { + /** + * How many activities before the queries used here are slow. Guessing. + */ + const ACTIVITY_THRESHOLD = 1000000; + public function setPreUpgradeMessage(&$preUpgradeMessage, $rev, $currentVer = NULL) { if ($rev === '5.57.alpha1') { - if (CRM_Core_DAO::singleValueQuery('SELECT COUNT(id) FROM civicrm_activity WHERE is_current_revision = 0')) { + // The query on is_current_revision is slow if there's a lot of activities. So limit when it gets run. + $activityCount = CRM_Core_DAO::singleValueQuery('SELECT MAX(id) FROM civicrm_activity'); + if ($activityCount < self::ACTIVITY_THRESHOLD && CRM_Core_DAO::singleValueQuery('SELECT COUNT(id) FROM civicrm_activity WHERE is_current_revision = 0')) { $preUpgradeMessage .= '

' . ts('Your database contains CiviCase activity revisions which are deprecated and will begin to appear as duplicates in SearchKit/api4/etc.

', [1 => 'target="_blank" href="https://lab.civicrm.org/-/snippets/85"']) . '

'; } + // Similarly the original_id ON DELETE drop+recreate is slow, so if we + // don't add the task farther down below, then tell people what to do at + // their convenience. + elseif ($activityCount >= self::ACTIVITY_THRESHOLD) { + $preUpgradeMessage .= '

' . ts('Your database contains too many activities to efficiently run a query needed to check for deprecated case activity revisions and to fix a bad foreign key constraint and it may take hours to run. You can run these queries manually at your convenience:

', [1 => 'target="_blank" href="https://lab.civicrm.org/-/snippets/85"']) . '

'; + } } } @@ -37,7 +50,9 @@ public function setPreUpgradeMessage(&$preUpgradeMessage, $rev, $currentVer = NU */ public function upgrade_5_57_alpha1($rev): void { $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev); - $this->addTask('Fix dangerous delete cascade', 'fixDeleteCascade'); + if (CRM_Core_DAO::singleValueQuery('SELECT MAX(id) FROM civicrm_activity') < self::ACTIVITY_THRESHOLD) { + $this->addTask('Fix dangerous delete cascade', 'fixDeleteCascade'); + } $this->addExtensionTask('Enable SearchKit extension', ['org.civicrm.search_kit'], 1100); $this->addExtensionTask('Enable Flexmailer extension', ['org.civicrm.flexmailer']); }