New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix environment variables to match README #1

Open

natejenkins wants to merge 1 commit into main from fix-environment-variable-names

Collaborator

natejenkins commented May 18, 2022

The README asks for the following in ~/.gradle/gradle.properties:

CITYMAPPER_API_KEY=[your API key]
CITYMAPPER_ENDPOINT_URL=[your API endpoint url]
CITYMAPPER_SAMPLE_GOOGLE_MAP_KEY=[your google map key]

However the module build.gradle has:

  buildConfigField "String", "CITYMAPPER_API_KEY", "\"${project.findProperty("SAMPLE_API_KEY") ?: ""}\""
  buildConfigField "String", "CITYMAPPER_ENDPOINT_URL", "\"${project.findProperty("SAMPLE_ENDPOINT_URL") ?: ""}\""

So it is looking for SAMPLE_API_KEY instead of CITYMAPPER_API_KEY.

Modifying these names fixes the demo.


          fix environment variables to match README

d43a87c

natejenkins requested a review from benkay

May 18, 2022 15:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet