Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go modules #14

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Use Go modules #14

merged 1 commit into from
Jan 2, 2019

Conversation

slai
Copy link

@slai slai commented Dec 14, 2018

This supercedes #11 by using the new Go modules system instead.

This supercedes #11 by using the new Go modules system instead.
@slai slai requested review from msf and oliland December 14, 2018 13:43
Copy link

@oliland oliland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📦

@msf
Copy link

msf commented Dec 17, 2018

This is great, what instructions did you follow ?
We should do this on goland... but that's a much bigger task...

@slai
Copy link
Author

slai commented Dec 31, 2018

I didn't write down the exact commands, but roughly it went -

# generate the gopkg.lock files (these aren't used later as they're part of dep)
dep init
# generate go.mod from gopkg.lock
go mod init <package name>
# can now delete the files created by dep

It's actually really simple. The annoying part is probably tweaking the version data to match what we had vendored.

@slai slai merged commit 3e226f5 into master Jan 2, 2019
@slai
Copy link
Author

slai commented Jan 2, 2019

Turns out go mod can also infer dependencies, so all that's necessary is -

go mod init <package name>
go build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants