Log if LISTDIR operation fails #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msf
approved these changes
Dec 11, 2018
oliland
approved these changes
Dec 15, 2018
slai
force-pushed
the
allow_env_credentials
branch
2 times, most recently
from
149c450
to
49d8690
Compare
Currently if a LISTDIR operation is requested but fails, there's no mention of it in the logs - the only way to know is through the response content, which is silently swallowed by pip.
slai
force-pushed
the
log_if_listdir_fails
branch
from
0ddc7db
to
ae53ca8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a LISTDIR operation is requested but fails, there's no mention of it in the logs - the only way to know is through the response content, which is silently swallowed by pip.