Vendor in dependencies #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been a while since go-minipypi has gotten any love, so let's bring it up to scratch with modern packaging practices. This PR vendors in all of the dependencies using `dep`. If anyone prefers using the new go modules support in Go 1.11, I'm happy to do that instead.
|
@slai lets use the new go modules if we're going to do this, might as well do it the "new" way. |
slai
added a commit
that referenced
this pull request
Dec 14, 2018
This supercedes #11 by using the new Go modules system instead.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since go-minipypi has gotten any love, so let's bring it up to scratch with modern packaging practices.
This PR vendors in all of the dependencies using
dep. If anyone prefers using the new go modules support in Go 1.11, I'm happy to do that instead.